tests: cleanup user configuration.#10445
Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom Jan 28, 2021
MikeMcQuaid:rspec_tmpdir_parallel
Merged
tests: cleanup user configuration.#10445MikeMcQuaid merged 2 commits intoHomebrew:masterfrom MikeMcQuaid:rspec_tmpdir_parallel
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
MikeMcQuaid:rspec_tmpdir_parallel
Conversation
This reverts commit 3724c73.
Contributor
|
Review period will end on 2021-01-29 at 09:04:56 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
added
the
critical
BrewTestBot
removed
the
waiting for feedback
Contributor
|
Review period skipped due to |
BrewTestBot
approved these changes
Jan 28, 2021
MikeMcQuaid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect this may be part of the cause of the flaky
cleanupspec.Also, while we're working on that, revert 3724c73 because it didn't make any different to the cleanup spec.