rubocops/lines: check for if ENV["CI"] usage.#10567
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Feb 12, 2021
MikeMcQuaid:env-ci-rubocop
Merged
rubocops/lines: check for if ENV["CI"] usage.#10567MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:env-ci-rubocop
if ENV["CI"] usage.#10567MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:env-ci-rubocop
Conversation
MikeMcQuaid
added
the
critical
Contributor
|
Review period ended. |
BrewTestBot
approved these changes
Feb 8, 2021
Member
|
The linux ones are part of the migration plan, and needed to be fixed. Most of these were added because we have no X display on CI. In that case either we find a test without X display, or let the test only run on macOS (better than nothing). |
Member
Author
@iMichka They actually just need changed en-masse like Homebrew/homebrew-core#70675. Once that's merged, shout and I can clean up the rest. |
MikeMcQuaid
removed
the
critical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested in Homebrew/homebrew-core#70675 (comment)