Skip to content

test/utils/git_spec: fix cherry pick test with older git#10588

Merged
Bo98 merged 1 commit intoHomebrew:masterfrom
Bo98:git-test-fix
Feb 11, 2021
Merged

test/utils/git_spec: fix cherry pick test with older git#10588
Bo98 merged 1 commit intoHomebrew:masterfrom
Bo98:git-test-fix

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Feb 10, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

(e.g. system git on Mojave)

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-02-11 at 17:37:09 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 10, 2021
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @Bo98!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 11, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@Bo98 Bo98 merged commit 7d91406 into Homebrew:master Feb 11, 2021
@Bo98 Bo98 deleted the git-test-fix branch February 11, 2021 17:41
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 14, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants