Skip to content

rubocop: use consistent array/hash indentation#10594

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Bo98:consistent-alignment
Feb 12, 2021
Merged

rubocop: use consistent array/hash indentation#10594
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Bo98:consistent-alignment

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Feb 11, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

As discussed in #10552 (review).

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-02-12 at 13:26:05 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 11, 2021
@Bo98 Bo98 force-pushed the consistent-alignment branch from a82fa37 to 323ff66 Compare February 11, 2021 13:27
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 💯 ❤️

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 12, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@MikeMcQuaid
Copy link
Copy Markdown
Member

MikeMcQuaid commented Feb 12, 2021

@Bo98 if this is just blocked on Homebrew/bundle I wouldn't mind disabling CI requirements there and then rerunning and merging here?

@Bo98
Copy link
Copy Markdown
Member Author

Bo98 commented Feb 12, 2021

I think that's the only way we can do it.

@MikeMcQuaid MikeMcQuaid merged commit 320bccb into Homebrew:master Feb 12, 2021
@Bo98 Bo98 deleted the consistent-alignment branch February 12, 2021 18:41
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 15, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants