Skip to content

Acceptable-Casks.md: first pass after moving#10602

Merged
vitorgalvao merged 1 commit intoHomebrew:masterfrom
vitorgalvao:acceptable-casks-pass
Feb 15, 2021
Merged

Acceptable-Casks.md: first pass after moving#10602
vitorgalvao merged 1 commit intoHomebrew:masterfrom
vitorgalvao:acceptable-casks-pass

Conversation

@vitorgalvao
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Followup to #10577 (comment):

I’ve noticed some things I’d like to change, but that’s a later PR.

May have missed a few things I noticed at first.

@vitorgalvao vitorgalvao added cask Homebrew Cask documentation Documentation changes labels Feb 12, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-02-15 at 00:38:51 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 12, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 15, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@vitorgalvao vitorgalvao merged commit cf8db02 into Homebrew:master Feb 15, 2021
@vitorgalvao vitorgalvao deleted the acceptable-casks-pass branch February 15, 2021 15:12
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 18, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cask Homebrew Cask documentation Documentation changes outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants