Skip to content

dependabot: allow indirect dependency updates#10604

Merged
Bo98 merged 1 commit intoHomebrew:masterfrom
Bo98:dependabot-indirect
Feb 15, 2021
Merged

dependabot: allow indirect dependency updates#10604
Bo98 merged 1 commit intoHomebrew:masterfrom
Bo98:dependabot-indirect

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Feb 12, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Old dependabot-preview used to do this. I think it's better for security reasons.

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-02-15 at 03:16:07 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 12, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 15, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@Bo98 Bo98 merged commit 7cef833 into Homebrew:master Feb 15, 2021
@Bo98 Bo98 deleted the dependabot-indirect branch February 15, 2021 04:49
@Bo98
Copy link
Copy Markdown
Member Author

Bo98 commented Feb 15, 2021

This matches what the docs suggest to do, though the last docs check didn't seem to check for anything more: https://github.com/Homebrew/brew/network/updates/88921829

@Bo98
Copy link
Copy Markdown
Member Author

Bo98 commented Feb 16, 2021

Tried it on a test repo with the same Gemfile(.lock):

Screenshot 2021-02-16 at 13 04 21

I guess something is bugged with this repo specifically 🤷‍♂️

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 18, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants