Skip to content

.github/ISSUE_TEMPLATE/{bug,feature}.yml: update syntax.#10607

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
MikeMcQuaid:update-issue-templates
Feb 15, 2021
Merged

.github/ISSUE_TEMPLATE/{bug,feature}.yml: update syntax.#10607
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
MikeMcQuaid:update-issue-templates

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Feb 12, 2021

This syntax is changing today and needs fixed CC @deniseyu and @Oneill38 for review.

@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Feb 12, 2021

Review period will end on 2021-02-15 at 10:41:31 UTC.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 12, 2021
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Feb 12, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Feb 12, 2021

Review period skipped due to critical label.

Oneill38
Oneill38 reviewed Feb 12, 2021
View reviewed changes
Copy link
Copy Markdown

@Oneill38 Oneill38 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to change inputs -> body and this is all good to go 🎉

@MikeMcQuaid
Apply suggestions from code review
3cb3b34 
Co-authored-by: Megan O'Neill <oneill38@github.com>
@MikeMcQuaid
Copy link
Copy Markdown
Member Author

MikeMcQuaid commented Feb 12, 2021

Thanks @Oneill38!

Oneill38
Oneill38 approved these changes Feb 12, 2021
View reviewed changes
Copy link
Copy Markdown

@Oneill38 Oneill38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@MikeMcQuaid MikeMcQuaid merged commit d7609b7 into Homebrew:master Feb 15, 2021
@MikeMcQuaid MikeMcQuaid deleted the update-issue-templates branch February 15, 2021 11:22
@Rylan12 Rylan12 mentioned this pull request Feb 15, 2021
Closed
@MikeMcQuaid MikeMcQuaid mentioned this pull request Feb 15, 2021
Merged
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 18, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

+1 more reviewer

@Oneill38 Oneill38 Oneill38 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MikeMcQuaid @BrewTestBot @Oneill38