Skip to content

style: use parentheses for assignment in conditions#10608

Merged
nandahkrishna merged 1 commit intoHomebrew:masterfrom
nandahkrishna:assignment-condition-parentheses
Feb 15, 2021
Merged

style: use parentheses for assignment in conditions#10608
nandahkrishna merged 1 commit intoHomebrew:masterfrom
nandahkrishna:assignment-condition-parentheses

Conversation

@nandahkrishna
Copy link
Copy Markdown
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This PR removes all Lint/AssignmentInCondition violations, which was listed as a # TODO in .rubocop.yml.

(Parentheses must be used to enclose assignment statements within conditions.)

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-02-15 at 13:05:57 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 12, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 15, 2021
@nandahkrishna nandahkrishna merged commit b9cbeb3 into Homebrew:master Feb 15, 2021
@nandahkrishna nandahkrishna deleted the assignment-condition-parentheses branch February 15, 2021 13:14
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 18, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants