Skip to content

prof: needs at least 1 argument#10614

Merged
jonchang merged 1 commit intoHomebrew:masterfrom
jonchang:brew-prof-min
Feb 15, 2021
Merged

prof: needs at least 1 argument#10614
jonchang merged 1 commit intoHomebrew:masterfrom
jonchang:brew-prof-min

Conversation

@jonchang
Copy link
Copy Markdown
Contributor

brew prof was incorrectly marked as having an optional argument, which is not correct as a bare brew prof will result in:

% brew prof
Error: undefined method `extname' for nil:NilClass
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/dev-cmd/prof.rb:30:in `prof'
/usr/local/Homebrew/Library/Homebrew/brew.rb:122:in `<main>'
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-02-16 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 14, 2021
@jonchang jonchang enabled auto-merge February 14, 2021 09:59
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 15, 2021
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @jonchang!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 15, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period skipped due to critical label.

@jonchang jonchang merged commit 4c26b9b into Homebrew:master Feb 15, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 18, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 18, 2021
@jonchang jonchang deleted the brew-prof-min branch June 13, 2021 00:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants