dev-cmd/prof: prevent from running on Apple Silicon#10691
Merged
dtrodrigues merged 1 commit intoHomebrew:masterfrom Feb 25, 2021
Merged
dev-cmd/prof: prevent from running on Apple Silicon#10691dtrodrigues merged 1 commit intoHomebrew:masterfrom
dtrodrigues merged 1 commit intoHomebrew:masterfrom
Conversation
Contributor
|
Review period will end on 2021-02-25 at 14:05:57 UTC. |
MikeMcQuaid
approved these changes
Feb 24, 2021
Contributor
|
Review period ended. |
BrewTestBot
approved these changes
Feb 25, 2021
1 task
Contributor
|
@dtrodrigues are these issues reported upstream somewhere? I couldn't find anything related in for either of the two profilers affected (ruby-prof and stackprof). |
Member
|
Yes: #10210 (comment). Reported to Apple under FB9002047. It's a system Ruby bug rather than anything specific to these profilers. A fix has already been prepared - it's just unknown exactly which macOS update it will land in. |
Member
Author
|
It's not an issue with the gem itself, but rather an issue with native gems using the system ruby on Apple Silicon which has been reported to Apple: #10210 (comment) |
Contributor
|
Explains why I couldn't find it. Thank you both for answering almost simultaneously. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?The prof command does not currently work on Apple silicon