homebrew_bootsnap: require some developer tools.#10694
homebrew_bootsnap: require some developer tools.#10694Bo98 merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:bootsnap_dev_tools
Conversation
Do a very basic developer tools check to ensure that we can compile things. We cannot use `DevelopmentTools.installed?` because this has much higher speed requirements and needs to be run before we `require` anything else.
|
Review period skipped due to |
|
Looks good. I actually think the check should be only on the I think there's some edge cases (like outdated CLT versions) that could go pass this - would it make any sense to make |
Makes sense to me 👍🏻
I'd rather not special case commands but the failure case should probably be made more graceful. |
Yeah, that would make sense. |
|
I'll merge this version now since there were a couple of reported problems from people with no dev tools. |
|
Thanks for merging @Bo98. |
Do a very basic developer tools check to ensure that we can compile things. We cannot use
DevelopmentTools.installed?because this has much higher speed requirements and needs to be run before werequireanything else.CC @Bo98 who mentioned this