Skip to content

docs/New-Maintainer-Checklist.md: remove automated steps#10725

Merged
nandahkrishna merged 1 commit intoHomebrew:masterfrom
nandahkrishna:maintainer-checklist-changes
Mar 2, 2021
Merged

docs/New-Maintainer-Checklist.md: remove automated steps#10725
nandahkrishna merged 1 commit intoHomebrew:masterfrom
nandahkrishna:maintainer-checklist-changes

Conversation

@nandahkrishna
Copy link
Copy Markdown
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR removes steps in the New Maintainer Checklist that have been automated (adding new maintainers to the README and running brew man, updating PLC members).

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-03-02 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 27, 2021
@nandahkrishna nandahkrishna added the documentation Documentation changes label Feb 27, 2021
Copy link
Copy Markdown
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nanda! 🌟

@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @nandahkrishna!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 2, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period ended.

@nandahkrishna nandahkrishna merged commit cc9a1df into Homebrew:master Mar 2, 2021
@nandahkrishna nandahkrishna deleted the maintainer-checklist-changes branch March 2, 2021 05:24
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Apr 2, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Documentation changes outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants