dev-cmd/tap-new: various tweaks.#10751
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Mar 2, 2021
MikeMcQuaid:brew-tap-new-tweaks
Merged
dev-cmd/tap-new: various tweaks.#10751MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:brew-tap-new-tweaks
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:brew-tap-new-tweaks
Conversation
Contributor
|
Review period will end on 2021-03-02 at 12:37:07 UTC. |
BrewTestBot
added
the
waiting for feedback
Rylan12
approved these changes
Mar 1, 2021
Member
Rylan12
left a comment
Rylan12
left a comment
There was a problem hiding this comment.
Looks good to me!
One minor thing: it may be a good idea to reword the --branch flag description to mention that it is also used to create the correct GitHub Actions workflows, even if --no-git is passed.
- `--no-git` and `--branch` don't conflict as `--branch` is still used for the GitHub Actions branch even with `--no-git` - fix some README markdown linting errors - fix some YAML/GitHub Actions configuration linting errors
Member
Author
Good idea, pushed! |
dawidd6
approved these changes
Mar 1, 2021
Rylan12
approved these changes
Mar 1, 2021
BrewTestBot
added
waiting for feedback
Contributor
|
Review period ended. |
BrewTestBot
removed
the
waiting for feedback
BrewTestBot
approved these changes
Mar 2, 2021
lithammer
added a commit
to lithammer/homebrew-deadsnakes
that referenced
this pull request
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--no-gitand--branchdon't conflict as--branchis still used for the GitHub Actions branch even with--no-git