Skip to content

download_strategy: add comment about Content-Disposition handling#10752

Merged
Bo98 merged 1 commit intoHomebrew:masterfrom
Bo98:content-disposition-comment
Mar 1, 2021
Merged

download_strategy: add comment about Content-Disposition handling#10752
Bo98 merged 1 commit intoHomebrew:masterfrom
Bo98:content-disposition-comment

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Mar 1, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Now that 3.0.3 is released, let's add this comment.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Mar 1, 2021
@Bo98 Bo98 requested a review from MikeMcQuaid March 1, 2021 14:01
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period skipped due to critical label.

@Bo98 Bo98 merged commit 1411430 into Homebrew:master Mar 1, 2021
@Bo98 Bo98 deleted the content-disposition-comment branch March 1, 2021 14:26
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Apr 1, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants