Skip to content

formula_installer: reduce dependency expansion computations#10792

Merged
Bo98 merged 1 commit intoHomebrew:masterfrom
Bo98:fi-less-dep-comp
Mar 8, 2021
Merged

formula_installer: reduce dependency expansion computations#10792
Bo98 merged 1 commit intoHomebrew:masterfrom
Bo98:fi-less-dep-comp

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Mar 6, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • Cache compute_dependencies calls so we don't recompute at fetch and install time.
  • Avoid compute_dependencies calls in the ignore_deps? case.

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-03-09 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 6, 2021
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some style comments but 👍🏻, nice work.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 8, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 8, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period skipped due to critical label.

@Bo98 Bo98 force-pushed the fi-less-dep-comp branch from 80bc819 to 96670ce Compare March 8, 2021 13:12
@Bo98 Bo98 merged commit 31a4989 into Homebrew:master Mar 8, 2021
@Bo98 Bo98 deleted the fi-less-dep-comp branch March 8, 2021 14:03
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants