dev-cmd/create: use std_configure_args#10801
Conversation
| @@ -156,10 +156,7 @@ def install | |||
| system "cmake", ".", *std_cmake_args | |||
| <% elsif mode == :autotools %> | |||
| # Remove unrecognized options if warned by configure | |||
There was a problem hiding this comment.
Can we link to https://rubydoc.brew.sh/Formula.html#std_configure_args-instance_method in this comment, so that users know what exactly is going into std_configure_args? Especially given that the comment might be asking them to remove options they don't even know are there...
There was a problem hiding this comment.
Should links be added for the other std_*_args also? Why add this link when there is already the link to https://rubydoc.brew.sh/Formula above?
There was a problem hiding this comment.
Should links be added for the other
std_*_argsalso?
Perhaps, but that's less important than for std_configure_args. There's very little need to know what the other std_*_args say: you can just include them and they'll just work. Not sure we can say the same for std_configure_args.
Why add this link when there is already the link to https://rubydoc.brew.sh/Formula above?
Same reasoning as above.
|
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @lexicol! |
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?