Skip to content

download_strategy: take basename of response-content-disposition query#10862

Merged
Bo98 merged 1 commit intoHomebrew:masterfrom
Bo98:ds_cd_fix
Mar 16, 2021
Merged

download_strategy: take basename of response-content-disposition query#10862
Bo98 merged 1 commit intoHomebrew:masterfrom
Bo98:ds_cd_fix

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Mar 16, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Mar 16, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Mar 16, 2021

Review period skipped due to critical label.

MikeMcQuaid
MikeMcQuaid approved these changes Mar 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using File.basename in these cases?

@Bo98
Copy link
Copy Markdown
Member Author

Bo98 commented Mar 16, 2021 •
edited
Loading

Sure, makes sense.

@Bo98 Bo98 enabled auto-merge March 16, 2021 15:18
MikeMcQuaid
MikeMcQuaid approved these changes Mar 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@Bo98 Bo98 merged commit 7df5f22 into Homebrew:master Mar 16, 2021
@Bo98 Bo98 added the security Pull requests that address a security vulnerability label Mar 16, 2021
@Bo98 Bo98 deleted the ds_cd_fix branch March 16, 2021 15:52
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees

No one assigned

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age security Pull requests that address a security vulnerability

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bo98 @BrewTestBot @MikeMcQuaid