Skip to content

Conversation

@MikeMcQuaid
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

For calculating the stable/devel versions this should be sufficient as it's looking at origin/master so for a e.g. unmerged pull request this will stop complaining about mistakes outside the pull request itself.

CC @ilovezfs

This will silence all warnings for historic version mistakes (i.e.
before these audit checks were all enabled) which is normally a bad
thing but as this case would rely on modifying history to complete is a
good one.

For calculating the stable/devel versions this should be sufficient as
it's looking at `origin/master` so for a e.g. unmerged pull request this
will stop complaining about mistakes outside the pull request itself.

This will silence all warnings for historic version mistakes (i.e.
before these audit checks were all enabled) which is normally a bad
thing but as this case would rely on modifying history to complete is a
good one.
@MikeMcQuaid MikeMcQuaid added the in progress Maintainers are working on this label Nov 16, 2016
@ilovezfs
Copy link
Contributor

This is probably the right approach. However, it still leaves unanswered the question of whether going forward we will have to address every future mistake (ab)using version_scheme. If it only goes back one, then it'll probably be fine to ignore the audit failure if the time period during which it was wrong is short, since the next time the audit check should go back to passing.

@MikeMcQuaid
Copy link
Member Author

since the next time the audit check should go back to passing.

Yes. This is basically just to address PRs from breaking these things silently.

@MikeMcQuaid MikeMcQuaid merged commit edf042e into Homebrew:master Nov 16, 2016
@MikeMcQuaid MikeMcQuaid deleted the audit-one-previous-commit branch November 16, 2016 10:25
@MikeMcQuaid MikeMcQuaid removed the in progress Maintainers are working on this label Nov 16, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants