Revert "Enable strict typing in Homebrew::TestBot"#21531
Merged
chenrui333 merged 1 commit intomainfrom Feb 6, 2026
Merged
Conversation
chenrui333
approved these changes
Feb 6, 2026
Member
|
this is probably better. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous change (PR #21506) that enabled strict typing in Homebrew::TestBot. The strict typing changes broke multiple workflows in homebrew-core, necessitating this revert.
Changes:
- Reverts typing level from
# typed: strictto# typed: trueacross all test_bot files - Removes Sorbet type signatures (
sigblocks) and type annotations (T.let,T.must, etc.) - Adds
.rbistub files for some classes/modules to maintain type checking support - Simplifies method calls by removing explicit
.to_sconversions on Pathnames
Reviewed changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/test_bot/test_runner.rb | Reverted strict typing, removed type signatures, simplified module to use module_function instead of class methods |
| Library/Homebrew/test_bot/test_runner.rbi | Added stub file for TestRunner module |
| Library/Homebrew/test_bot/test_formulae.rb | Reverted strict typing, removed type signatures and annotations |
| Library/Homebrew/test_bot/test_formulae.rbi | Added stub file for TestFormulae class |
| Library/Homebrew/test_bot/test_cleanup.rb | Reverted strict typing, removed .to_s conversions for Pathname arguments |
| Library/Homebrew/test_bot/test.rb | Reverted strict typing, combined attr_reader declarations |
| Library/Homebrew/test_bot/tap_syntax.rb | Reverted strict typing, simplified method implementation |
| Library/Homebrew/test_bot/step.rb | Reverted strict typing, removed type annotations |
| Library/Homebrew/test_bot/setup.rb | Reverted strict typing |
| Library/Homebrew/test_bot/junit.rb | Reverted strict typing, removed T.must assertions |
| Library/Homebrew/test_bot/formulae_detect.rb | Reverted strict typing, simplified early return logic |
| Library/Homebrew/test_bot/formulae_dependents.rb | Reverted strict typing, simplified attr_writer declarations |
| Library/Homebrew/test_bot/formulae.rb | Reverted strict typing, removed complex initialization type annotations |
| Library/Homebrew/test_bot/cleanup_before.rb | Reverted strict typing |
| Library/Homebrew/test_bot/cleanup_after.rb | Reverted strict typing |
| Library/Homebrew/test_bot/bottles_fetch.rb | Reverted strict typing |
| Library/Homebrew/test_bot.rb | Reverted strict typing in main module |
| Library/Homebrew/test/test_bot/setup_spec.rb | Updated test to use correct class reference |
Files not reviewed (2)
- Library/Homebrew/test_bot/test_formulae.rbi: Language not supported
- Library/Homebrew/test_bot/test_runner.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #21506
This PR breaks a lot of different workflows in homebrew-core:
https://github.com/Homebrew/homebrew-core/actions/runs/21745012156/job/62728656357
https://github.com/Homebrew/homebrew-core/actions/runs/21744079032/job/62725959075
https://github.com/Homebrew/homebrew-core/actions/runs/21744048095/job/62725855729