Skip to content

Revert "Enable strict typing in Homebrew::TestBot"#21531

Merged
chenrui333 merged 1 commit intomainfrom
revert-21506-test-bot-strict-typing
Feb 6, 2026
Merged

Revert "Enable strict typing in Homebrew::TestBot"#21531
chenrui333 merged 1 commit intomainfrom
revert-21506-test-bot-strict-typing

Conversation

Copilot AI review requested due to automatic review settings February 6, 2026 09:33
@chenrui333 chenrui333 enabled auto-merge February 6, 2026 09:36
@chenrui333
Copy link
Member

this is probably better.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previous change (PR #21506) that enabled strict typing in Homebrew::TestBot. The strict typing changes broke multiple workflows in homebrew-core, necessitating this revert.

Changes:

  • Reverts typing level from # typed: strict to # typed: true across all test_bot files
  • Removes Sorbet type signatures (sig blocks) and type annotations (T.let, T.must, etc.)
  • Adds .rbi stub files for some classes/modules to maintain type checking support
  • Simplifies method calls by removing explicit .to_s conversions on Pathnames

Reviewed changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Library/Homebrew/test_bot/test_runner.rb Reverted strict typing, removed type signatures, simplified module to use module_function instead of class methods
Library/Homebrew/test_bot/test_runner.rbi Added stub file for TestRunner module
Library/Homebrew/test_bot/test_formulae.rb Reverted strict typing, removed type signatures and annotations
Library/Homebrew/test_bot/test_formulae.rbi Added stub file for TestFormulae class
Library/Homebrew/test_bot/test_cleanup.rb Reverted strict typing, removed .to_s conversions for Pathname arguments
Library/Homebrew/test_bot/test.rb Reverted strict typing, combined attr_reader declarations
Library/Homebrew/test_bot/tap_syntax.rb Reverted strict typing, simplified method implementation
Library/Homebrew/test_bot/step.rb Reverted strict typing, removed type annotations
Library/Homebrew/test_bot/setup.rb Reverted strict typing
Library/Homebrew/test_bot/junit.rb Reverted strict typing, removed T.must assertions
Library/Homebrew/test_bot/formulae_detect.rb Reverted strict typing, simplified early return logic
Library/Homebrew/test_bot/formulae_dependents.rb Reverted strict typing, simplified attr_writer declarations
Library/Homebrew/test_bot/formulae.rb Reverted strict typing, removed complex initialization type annotations
Library/Homebrew/test_bot/cleanup_before.rb Reverted strict typing
Library/Homebrew/test_bot/cleanup_after.rb Reverted strict typing
Library/Homebrew/test_bot/bottles_fetch.rb Reverted strict typing
Library/Homebrew/test_bot.rb Reverted strict typing in main module
Library/Homebrew/test/test_bot/setup_spec.rb Updated test to use correct class reference
Files not reviewed (2)
  • Library/Homebrew/test_bot/test_formulae.rbi: Language not supported
  • Library/Homebrew/test_bot/test_runner.rbi: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenrui333 chenrui333 added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit cf63ae0 Feb 6, 2026
43 checks passed
@chenrui333 chenrui333 deleted the revert-21506-test-bot-strict-typing branch February 6, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants