Bundle: use full formula name for upgrade checks#21554
Merged
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom Feb 10, 2026
Merged
Bundle: use full formula name for upgrade checks#21554MikeMcQuaid merged 1 commit intoHomebrew:mainfrom
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
brew bundlefails to upgrade tapped formulae when they shadow a homebrew-core formula name.The Problem:
The
upgradable?method informula_installer.rbwas using@name(short name like "tart") instead of@full_name(full name like "cirruslabs/cli/tart") when checking if a formula can be upgraded. This causedFormula[formula]to resolve to the deprecated homebrew-core formula instead of the intended tapped formula.The Fix:
Changed line 237 to use
@full_nameinstead of@name, ensuringFormula[]resolves to the correct tapped formula.Fixes #21521
brew lgtm(style, typechecking and tests) with your changes locally?