Skip to content

Comments

Bundle: use full formula name for upgrade checks#21554

Merged
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom
ooye-sanket:patch-5
Feb 10, 2026
Merged

Bundle: use full formula name for upgrade checks#21554
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom
ooye-sanket:patch-5

Conversation

@ooye-sanket
Copy link
Contributor

This PR fixes a bug where brew bundle fails to upgrade tapped formulae when they shadow a homebrew-core formula name.

The Problem:
The upgradable? method in formula_installer.rb was using @name (short name like "tart") instead of @full_name (full name like "cirruslabs/cli/tart") when checking if a formula can be upgraded. This caused Formula[formula] to resolve to the deprecated homebrew-core formula instead of the intended tapped formula.

The Fix:
Changed line 237 to use @full_name instead of @name, ensuring Formula[] resolves to the correct tapped formula.

Fixes #21521

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Feb 10, 2026
Merged via the queue into Homebrew:main with commit 8ab3982 Feb 10, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tap won't upgrade when running brew bundle

2 participants