Fix remote tab sometimes being used for local bottle installs#21743
Merged
Fix remote tab sometimes being used for local bottle installs#21743
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an edge case where installing from a local bottle path could incorrectly use remote bottle tab attributes (potentially from a different version), by explicitly gating remote-tab usage on formula.local_bottle_path not being set.
Changes:
- Avoid using
formula.bottle_tab_attributeswhen installing from a local bottle (prefer local JSON/tab sources instead). - Skip fetching the remote bottle manifest/tab during local bottle installs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Library/Homebrew/utils/bottles.rb | Prevents remote bottle tab attributes from being used when a local bottle path is present. |
| Library/Homebrew/formula_installer.rb | Skips remote bottle tab/manifest fetching when installing from a local bottle path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing from a local bottle (
brew install ./bottle.tar.gz), either the tab.jsonfound alongside the bottle or the tab inside the bottle tarball is expected to be used. This logic was triggered under conditional on there not being a bottle block, which is normally true if you are loading the formula from the bottle tarball itself.However, it is possible that if the formula inside the bottle tarball is unreadable it will fall back to the tap's formula which does have a bottle block. This would then fetch and use the remote tab attributes which is incorrect as that's possibly for a different version of the formula.
Instead, let's correctly add explicit
formula.local_bottle_pathchecks that were previously implied under the normal scenario.The set of circumstances described to force a fallback onto the tap formula is rare and did not happen with any first-party Homebrew/core formula. It would require using syntax that is currently not able to be bottled, such as
require_relative.https://github.com/orgs/Homebrew/discussions/6753