brew.sh: calculate HOMEBREW_MACOS_VERSION_NUMERIC earlier.#21752
Merged
MikeMcQuaid merged 1 commit intomainfrom Mar 17, 2026
Merged
brew.sh: calculate HOMEBREW_MACOS_VERSION_NUMERIC earlier.#21752MikeMcQuaid merged 1 commit intomainfrom
MikeMcQuaid merged 1 commit intomainfrom
Conversation
This is needed by `brew shellenv`.
6 tasks
Bo98
approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Moves macOS version detection earlier in brew.sh so brew shellenv can rely on HOMEBREW_MACOS_VERSION_NUMERIC being set before cmd/shellenv.sh runs.
Changes:
- Compute
HOMEBREW_MACOS_VERSIONandHOMEBREW_MACOS_VERSION_NUMERICnear the top ofbrew.sh. - Remove the later initialization of these variables further down in
brew.sh.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed by
brew shellenv.