Skip to content

Do not allow setting HOMEBREW_EXPERIMENTAL_RUST_FRONTEND in env file#21803

Merged
MikeMcQuaid merged 1 commit intomainfrom
no-rust-env-file
Mar 22, 2026
Merged

Do not allow setting HOMEBREW_EXPERIMENTAL_RUST_FRONTEND in env file#21803
MikeMcQuaid merged 1 commit intomainfrom
no-rust-env-file

Conversation

@carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

We rely on being able to unset this environment variable when handing
back to Ruby, but we won't be able to unset this if we got it from an
env file.

Copilot AI review requested due to automatic review settings March 22, 2026 16:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@carlocab carlocab requested a review from Copilot March 22, 2026 16:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@carlocab
Copy link
Member Author

Hm, weird. I really did run brew lgtm.

We rely on being able to `unset` this environment variable when handing
back to Ruby, but we won't be able to unset this if we got it from an
env file.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Mar 22, 2026
Merged via the queue into main with commit 71bb136 Mar 22, 2026
40 checks passed
@MikeMcQuaid MikeMcQuaid deleted the no-rust-env-file branch March 22, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants