Skip to content

workflows/tests: migrate from deprecated test-results-action#21815

Merged
Bo98 merged 1 commit intomainfrom
codecov-test-results-action
Mar 24, 2026
Merged

workflows/tests: migrate from deprecated test-results-action#21815
Bo98 merged 1 commit intomainfrom
codecov-test-results-action

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Mar 24, 2026

It's been merged into codecov-action: https://github.com/codecov/test-results-action?tab=readme-ov-file#%EF%B8%8F-deprecation-warning-%EF%B8%8F

Also update to 5.5.3 since that's the first version with node24 support.

Copilot AI review requested due to automatic review settings March 24, 2026 00:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates CI test result uploads off the deprecated codecov/test-results-action by using the newer codecov/codecov-action test-results mode, and bumps Codecov action to a Node 24–compatible release.

Changes:

  • Replace codecov/test-results-action with codecov/codecov-action configured with report_type: test_results.
  • Bump codecov/codecov-action from v5.5.2 to v5.5.3 (Node 24 support).
Comments suppressed due to low confidence (1)

.github/workflows/tests.yml:316

  • Similarly, this coverage upload step runs even when tests are skipped (notably the tests (online) matrix entry on push events). That can lead to a noisy Codecov no-op/error when coverage.xml wasn't generated. Consider adding an if: guard aligned with the test execution (or checking that the coverage file exists) so uploads only run when reports are present.
      - uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5.5.3
        with:
          working-directory: ${{ steps.set-up-homebrew.outputs.repository-path }}
          files: Library/Homebrew/test/coverage/coverage.xml
          disable_search: true

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Bo98 Bo98 added this pull request to the merge queue Mar 24, 2026
Merged via the queue into main with commit 054e55b Mar 24, 2026
62 of 64 checks passed
@Bo98 Bo98 deleted the codecov-test-results-action branch March 24, 2026 03:19
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants