Adjust update to honor custom SSH command#21822
Open
sfc-gh-ksmogor wants to merge 3 commits intoHomebrew:mainfrom
Open
Adjust update to honor custom SSH command#21822sfc-gh-ksmogor wants to merge 3 commits intoHomebrew:mainfrom
sfc-gh-ksmogor wants to merge 3 commits intoHomebrew:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my use case I use custom ssh command to access homebrew repositories (set as a global config in
~/.gitconfigfile). Currentbrew updatedoesn't work with my custom repository because of wrong credentials. Tapping still works as expected.It turned out that setting up explicit
GIT_SSH_COMMAND=${GIT_SSH_COMMAND:-ssh} -oBatchMode=yesoverrides global git config. Additionally, I couldn't override the defaultsshcommand by exportingGIT_SSH_COMMAND. It happened because the flag wasn't whitelisted.I propose to fix two things:
-oBatchModeonly when default ssh implementation is used. Otherwise brew can break custom wrapper by adding ssh-only flag.update.sh.brew lgtm(style, typechecking and tests) with your changes locally?Used for searching the code through and diagnosing the problem with passing the flag to update (comparison between tap and update, suggesting the change when problem was pinned down by local modification).