brew-rs/fetch: use functions from tty module#21825
Merged
MikeMcQuaid merged 2 commits intomainfrom Mar 24, 2026
Merged
Conversation
Signed-off-by: botantony <antonsm21@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors brew-rs fetch to rely on the shared utils::tty module for ANSI color and terminal control sequences, consolidating previously inlined escape codes and expanding the TTY helper surface.
Changes:
- Add green ANSI support and new cursor/line control helpers to
utils::tty. - Replace hardcoded ANSI escape sequences in
fetchwith calls intoutils::tty. - Simplify
fetch_bottle/print_downloaded_bottleby removing the explicittty_outputparameter and delegating color decisions totty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Library/Homebrew/rust/brew-rs/src/utils/tty.rs |
Adds green ANSI support and introduces reusable cursor/line control helpers for terminal output. |
Library/Homebrew/rust/brew-rs/src/commands/fetch.rs |
Switches progress rendering and status output to use the new tty helpers instead of embedded escape sequences. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?I didn't check this module #21809