generate-cask-ci-matrix: fix Linux runner for single-arch casks#21970
Merged
MikeMcQuaid merged 1 commit intomainfrom Apr 10, 2026
Merged
generate-cask-ci-matrix: fix Linux runner for single-arch casks#21970MikeMcQuaid merged 1 commit intomainfrom
MikeMcQuaid merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CI matrix generation for casks that are single-arch on macOS (e.g., arm64-only) but support both Linux architectures, ensuring the missing Linux runner is included.
Changes:
- Expand the runner/architecture product to include Linux architectures for Linux-supported casks.
- Add a guard to prevent macOS runners from generating simulated-arch jobs that aren’t valid for macOS in the current cask context.
- Add a new spec fixture/assertion covering a macOS-
arm64-only cask that supports Linux.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb |
Includes Linux architectures in job generation and skips invalid macOS simulated-arch combinations. |
Library/Homebrew/test/dev-cmd/generate-cask-ci-matrix_spec.rb |
Adds a new cask scenario and expectation for runner filtering behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Patrick Linnane <patrick@linnane.io>
78d5ae0 to
916ee20
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?I used Claude Code, manually reviewed the code, validated locally.
Casks that only support one macOS architecture (
arm64-only) but both Linux architectures were missing the second Linux runner from the CI matrix. The runner product only used macOS architectures, an Intel Linux runner paired witharm64was skipped as non-native.Fix by including Linux architectures in the product and guarding against macOS runners simulating architectures that don't exist on macOS.