Skip to content

generate-cask-ci-matrix: fix Linux runner for single-arch casks#21970

Merged
MikeMcQuaid merged 1 commit intomainfrom
fix-cask-ci-matrix-linux-arch
Apr 10, 2026
Merged

generate-cask-ci-matrix: fix Linux runner for single-arch casks#21970
MikeMcQuaid merged 1 commit intomainfrom
fix-cask-ci-matrix-linux-arch

Conversation

@p-linnane
Copy link
Copy Markdown
Member


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

I used Claude Code, manually reviewed the code, validated locally.


Casks that only support one macOS architecture (arm64-only) but both Linux architectures were missing the second Linux runner from the CI matrix. The runner product only used macOS architectures, an Intel Linux runner paired with arm64 was skipped as non-native.

Fix by including Linux architectures in the product and guarding against macOS runners simulating architectures that don't exist on macOS.

Copilot AI review requested due to automatic review settings April 9, 2026 23:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes CI matrix generation for casks that are single-arch on macOS (e.g., arm64-only) but support both Linux architectures, ensuring the missing Linux runner is included.

Changes:

  • Expand the runner/architecture product to include Linux architectures for Linux-supported casks.
  • Add a guard to prevent macOS runners from generating simulated-arch jobs that aren’t valid for macOS in the current cask context.
  • Add a new spec fixture/assertion covering a macOS-arm64-only cask that supports Linux.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb Includes Linux architectures in job generation and skips invalid macOS simulated-arch combinations.
Library/Homebrew/test/dev-cmd/generate-cask-ci-matrix_spec.rb Adds a new cask scenario and expectation for runner filtering behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Apr 10, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2026
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit e02cbd3 Apr 10, 2026
42 checks passed
@MikeMcQuaid MikeMcQuaid deleted the fix-cask-ci-matrix-linux-arch branch April 10, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants