Skip to content

Fix flaky run_actionlint! tests#21975

Merged
MikeMcQuaid merged 1 commit intomainfrom
fix-more-flaky-tests
Apr 10, 2026
Merged

Fix flaky run_actionlint! tests#21975
MikeMcQuaid merged 1 commit intomainfrom
fix-more-flaky-tests

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

  • Seed $CHILD_STATUS with system("true") before stubbing so it is non-nil when the code calls $CHILD_STATUS.success? after the stubbed system

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

OpenAI Codex with manual/local review and testing.


- Seed `$CHILD_STATUS` with `system("true")` before
  stubbing so it is non-nil when the code calls
  `$CHILD_STATUS.success?` after the stubbed `system`
Copilot AI review requested due to automatic review settings April 10, 2026 08:01
@MikeMcQuaid MikeMcQuaid enabled auto-merge April 10, 2026 08:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Stabilizes the Homebrew::Style.run_actionlint! specs by ensuring $CHILD_STATUS is initialized before system is stubbed, preventing nil.success? failures.

Changes:

  • Seed $CHILD_STATUS via a trivial successful system("true") call in the run_actionlint! spec setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit 776ae84 Apr 10, 2026
42 checks passed
@MikeMcQuaid MikeMcQuaid deleted the fix-more-flaky-tests branch April 10, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants