rubydoc: undo temporary yard fix#21999
Merged
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom Apr 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the temporary Homebrew-side YARD JavaScript workaround now that the underlying issue has been fixed upstream in YARD, and updates the locked YARD version accordingly.
Changes:
- Bump
yardfrom0.9.38to0.9.39inLibrary/Homebrew/Gemfile.lock. - Remove the temporary
app.jspatch file and the workflow step that applied it. - Drop the locally-vendored
app.jsoverride underLibrary/Homebrew/yard/templates/....
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Library/Homebrew/yard/templates/default/fulldoc/html/js/app.js.patch |
Removes the now-unneeded patch that modified YARD’s app.js. |
Library/Homebrew/yard/templates/default/fulldoc/html/js/app.js |
Removes the local JS override so upstream YARD’s template JS is used. |
Library/Homebrew/Gemfile.lock |
Updates the locked YARD version to include the upstream fix. |
.github/workflows/docs.yml |
Stops applying the patch during docs builds since it’s no longer needed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e72cf61 to
01225f6
Compare
MikeMcQuaid
approved these changes
Apr 13, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks again @GunniBusch!
Contributor
Author
Thank you and your team for maintaining the best package manager! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Undo the temporary change made by #21589. The issue was solved by lsegal/yard@ae63056
Edit:
Of course it also bumps yard.