Skip to content

rubydoc: undo temporary yard fix#21999

Merged
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom
GunniBusch:rubydoc-fix-undo
Apr 13, 2026
Merged

rubydoc: undo temporary yard fix#21999
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom
GunniBusch:rubydoc-fix-undo

Conversation

@GunniBusch
Copy link
Copy Markdown
Contributor

@GunniBusch GunniBusch commented Apr 12, 2026


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Undo the temporary change made by #21589. The issue was solved by lsegal/yard@ae63056

Edit:

Of course it also bumps yard.

Copilot AI review requested due to automatic review settings April 12, 2026 16:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the temporary Homebrew-side YARD JavaScript workaround now that the underlying issue has been fixed upstream in YARD, and updates the locked YARD version accordingly.

Changes:

  • Bump yard from 0.9.38 to 0.9.39 in Library/Homebrew/Gemfile.lock.
  • Remove the temporary app.js patch file and the workflow step that applied it.
  • Drop the locally-vendored app.js override under Library/Homebrew/yard/templates/....

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
Library/Homebrew/yard/templates/default/fulldoc/html/js/app.js.patch Removes the now-unneeded patch that modified YARD’s app.js.
Library/Homebrew/yard/templates/default/fulldoc/html/js/app.js Removes the local JS override so upstream YARD’s template JS is used.
Library/Homebrew/Gemfile.lock Updates the locked YARD version to include the upstream fix.
.github/workflows/docs.yml Stops applying the patch during docs builds since it’s no longer needed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @GunniBusch!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Apr 13, 2026
@GunniBusch
Copy link
Copy Markdown
Contributor Author

Thanks again @GunniBusch!

Thank you and your team for maintaining the best package manager!

Merged via the queue into Homebrew:main with commit c21100b Apr 13, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants