Skip to content

cask/artifact/qlplugin: fix type override#22004

Merged
MikeMcQuaid merged 1 commit intomainfrom
qlplugin-type-fix
Apr 13, 2026
Merged

cask/artifact/qlplugin: fix type override#22004
MikeMcQuaid merged 1 commit intomainfrom
qlplugin-type-fix

Conversation

@bevanjkay
Copy link
Copy Markdown
Member


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Claude was used to help add the correct type override to match the parent.


This PR adds missing sig parameters from the parent Moved that is inherited by qlplugin but was missing from the override.

Resolves: https://github.com/orgs/Homebrew/discussions/6797

Copilot AI review requested due to automatic review settings April 13, 2026 06:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Sorbet override method signatures in Cask::Artifact::Qlplugin so they match the parent Cask::Artifact::Moved method keyword parameters.

Changes:

  • Add successor: to Qlplugin#install_phase sig and method parameters.
  • Update Qlplugin#uninstall_phase sig and method parameters to include verbose:, successor:, upgrade:, and reinstall: (matching Moved).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit 299ab19 Apr 13, 2026
42 checks passed
@MikeMcQuaid MikeMcQuaid deleted the qlplugin-type-fix branch April 13, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants