utils/github: use WithoutRuntime sig for create_bump_pr#22012
Merged
Conversation
The sig for `create_bump_pr` references `BumpCaskPr::Args` which may not be loaded yet, causing `uninitialized constant` errors in CI (e.g. homebrew-core autobump). Switch to `T::Sig::WithoutRuntime.sig` so the type is resolved lazily.
Bo98
approved these changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Sorbet typing for Utils::GitHub.create_bump_pr to avoid CI failures caused by eager constant resolution of Homebrew::DevCmd::BumpCaskPr during class load.
Changes:
- Replaces the eager
sigoncreate_bump_prwithT::Sig::WithoutRuntime.sigto preventuninitialized constant Homebrew::DevCmd::BumpCaskPrerrors in CI autobump jobs. - Adds an inline comment explaining why
WithoutRuntimeis required here.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
uninitialized constant Homebrew::DevCmd::BumpCaskPrerrors inhomebrew-core CI autobump jobs by switching the
create_bump_prsigto
T::Sig::WithoutRuntime.sig, which resolves the type lazilyinstead of at class load time.
See: https://github.com/Homebrew/homebrew-core/actions/runs/24371330931/job/71175423834#step:6:1307
brew lgtm(style, typechecking and tests) with your changes locally?