Skip to content

fix: allow absolute --path/--dir for typechecking#22029

Open
danielbayley wants to merge 2 commits intoHomebrew:mainfrom
danielbayley:typecheck
Open

fix: allow absolute --path/--dir for typechecking#22029
danielbayley wants to merge 2 commits intoHomebrew:mainfrom
danielbayley:typecheck

Conversation

@danielbayley
Copy link
Copy Markdown
Contributor

@danielbayley danielbayley commented Apr 16, 2026

Currently, any --path/--dir given to brew typecheck is forcibly prefixed with ../, which breaks this functionality under most circumstances. This PR enables passing an absolute --path, or --dir to typecheck, with the goal being that we can make use of it with 3rd party taps…


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes. Non-maintainers may only have one AI-assisted/generated PR open at a time.

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks! One comment.

Comment thread Library/Homebrew/dev-cmd/typecheck.rb Outdated
Comment thread Library/Homebrew/dev-cmd/typecheck.rb Outdated
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants