Merged
Conversation
- avoid live `pypi.org` lookups in `cmd/source` specs so the regression is deterministic - keep coverage on `pypi_repo_url` package parsing by asserting the expected JSON API request
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the cmd/source PyPI URL specs by removing live pypi.org dependency and asserting the expected JSON API request, making the regression test deterministic.
Changes:
- Stub
Utils::Curl.curl_outputin#pypi_repo_urlspecs to avoid network access. - Assert the exact PyPI JSON API URL requested for given PyPI package tarball URLs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pypi.orglookups incmd/sourcespecs so the regression is deterministicpypi_repo_urlpackage parsing by asserting the expected JSON API requestbrew lgtm(style, typechecking and tests) with your changes locally?Used OpenAI Codex xhigh with manual review.