Skip to content

rubocops/resource_requires_dependencies: add bcrypt#22055

Merged
MikeMcQuaid merged 1 commit intomainfrom
resource-requires-dependencies-bcrypt
Apr 22, 2026
Merged

rubocops/resource_requires_dependencies: add bcrypt#22055
MikeMcQuaid merged 1 commit intomainfrom
resource-requires-dependencies-bcrypt

Conversation

@p-linnane
Copy link
Copy Markdown
Member

@p-linnane p-linnane commented Apr 21, 2026

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes. Non-maintainers may only have one AI-assisted/generated PR open at a time.

Claude Code was used to locate the existing ResourceRequiresDependencies cop, add the bcrypt entry and corresponding specs, and run brew lgtm locally. I reviewed the diff and verified the specs match the pattern used by the existing lxml/pynacl/pyyaml checks.


Flags Python formulae that include the bcrypt resource but don't declare the pkgconf and rust build dependencies it needs to build from source. Follow-up to the standardization in Homebrew/homebrew-core#278702.

Flag formulae that include the `bcrypt` Python resource but don't
declare `pkgconf` and `rust` as dependencies, as required to build it
from source.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 21, 2026 19:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds bcrypt to the FormulaAudit/ResourceRequiresDependencies RuboCop cop so Python formulae using the bcrypt resource are audited for required dependencies.

Changes:

  • Extend the cop to recognize the bcrypt resource and require pkgconf + rust.
  • Add spec coverage for formulas with/without bcrypt, and with missing dependencies.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
Library/Homebrew/rubocops/resource_requires_dependencies.rb Adds bcrypt handling and required dependency list for the audit cop.
Library/Homebrew/test/rubocops/resource_requires_dependencies_spec.rb Adds tests covering bcrypt resource scenarios.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/rubocops/resource_requires_dependencies.rb
Comment thread Library/Homebrew/rubocops/resource_requires_dependencies.rb
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Apr 22, 2026
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks!

Merged via the queue into main with commit e599124 Apr 22, 2026
59 of 60 checks passed
@MikeMcQuaid MikeMcQuaid deleted the resource-requires-dependencies-bcrypt branch April 22, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants