rubocops/resource_requires_dependencies: add bcrypt#22055
Merged
MikeMcQuaid merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
Flag formulae that include the `bcrypt` Python resource but don't declare `pkgconf` and `rust` as dependencies, as required to build it from source. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds bcrypt to the FormulaAudit/ResourceRequiresDependencies RuboCop cop so Python formulae using the bcrypt resource are audited for required dependencies.
Changes:
- Extend the cop to recognize the
bcryptresource and requirepkgconf+rust. - Add spec coverage for formulas with/without
bcrypt, and with missing dependencies.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Library/Homebrew/rubocops/resource_requires_dependencies.rb |
Adds bcrypt handling and required dependency list for the audit cop. |
Library/Homebrew/test/rubocops/resource_requires_dependencies_spec.rb |
Adds tests covering bcrypt resource scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Apr 22, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Claude Code was used to locate the existing
ResourceRequiresDependenciescop, add thebcryptentry and corresponding specs, and runbrew lgtmlocally. I reviewed the diff and verified the specs match the pattern used by the existinglxml/pynacl/pyyamlchecks.Flags Python formulae that include the
bcryptresource but don't declare thepkgconfandrustbuild dependencies it needs to build from source. Follow-up to the standardization in Homebrew/homebrew-core#278702.