Reject unsupported API casks earlier#22070
Merged
MikeMcQuaid merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
- stop `gimp` on Linux before source reloads fail - avoid queued downloads for unsupported API-backed casks - cover `fetch` and `enqueue_downloads` with regression tests
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes cask installation flow to fail fast on unsupported API-backed casks (before attempting API source reloads or queueing downloads), with regression tests covering both fetch and download prefetching.
Changes:
- Run
check_requirementsbeforeload_cask_from_source_api!inCask::Installer#fetch. - Run
check_requirementsat the start ofCask::Installer#enqueue_downloadsto prevent queuing downloads for unsupported casks. - Add installer specs ensuring API source download paths are not invoked when requirements are unsatisfied.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/cask/installer.rb | Reorders/introduces requirement checks to reject unsupported API-backed casks earlier in fetch and enqueue_downloads. |
| Library/Homebrew/test/cask/installer_spec.rb | Adds regression tests asserting requirements are validated before any API source-download work in fetch and before prefetch enqueuing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gimpon Linux before source reloads failfetchandenqueue_downloadswith regression testsbrew lgtm(style, typechecking and tests) with your changes locally?Used OpenAI Codex xhigh with local review.