Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens Homebrew .pkg installs/updates against local Git customizations by removing repository-local hooks/config and adding a brew doctor warning when they’re detected.
Changes:
- Remove
.git/hooksand repository-local.gitconfigduring.pkgpostinstall repository reset. - Add a new
brew doctorcheck to warn whenHomebrew/brewcontains Git hooks or a repo-local.gitconfig. - Add RSpec coverage for the new diagnostic check (including ignoring
*.samplehooks).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
package/scripts/postinstall |
Removes repo-local Git hooks and .gitconfig during .pkg installation/reset steps. |
Library/Homebrew/diagnostic.rb |
Adds check_homebrew_repository_git_hooks to surface problematic Git customizations in brew doctor. |
Library/Homebrew/test/diagnostic_checks_spec.rb |
Adds unit tests validating the new diagnostic output and .sample hook exclusion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- remove local Git hooks and `.gitconfig` during `.pkg` installs - warn in `brew doctor` when the `Homebrew/brew` repo contains them - avoid local Git customisations breaking installs or updates
5547725 to
9421ad1
Compare
ZhongRuoyu
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitconfigduring.pkginstallsbrew doctorwhen theHomebrew/brewrepo contains thembrew lgtm(style, typechecking and tests) with your changes locally?Used OpenAI Codex with manual/local review and editing.