Open
Conversation
- document `HOMEBREW_SBOM` ahead of the 5.2.0 default change - keep 5.1.x behaviour unchanged while `test-bot` exercises it - leave release reminders where install-time SBOM work will tighten
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares Homebrew for making SBOM generation opt-in via a new HOMEBREW_SBOM environment variable, with early wiring for CI/test-bot and TODO markers for the upcoming behavior change in 5.2.0.
Changes:
- Set
HOMEBREW_SBOM=1inbrew test-bot’s environment. - Add
HOMEBREW_SBOMtoHomebrew::EnvConfig::ENVS(documented as a no-op until 5.2.0). - Add 5.2.0 TODO/
odeprecatednotes around SBOM requiring/lazy-loading inFormulaInstaller.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Library/Homebrew/test_bot.rb | Forces HOMEBREW_SBOM in the test-bot environment. |
| Library/Homebrew/formula_installer.rb | Adds TODO notes indicating future gating/lazy-loading for SBOM. |
| Library/Homebrew/env_config.rb | Documents a new HOMEBREW_SBOM boolean env var in EnvConfig. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality is not widely used and it's relatively slow. Let's make it an opt-in for those who need it in 5.2.0.
brew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex with several rounds of local tweaking and review.