Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the macOS installer packaging flow to keep a pristine packaged Git directory in .git.pkg and then replace the installed .git directory via renames before running privileged Git commands, including during Intel /usr/local reinstalls.
Changes:
- Add cleanup of
${homebrew_directory}/.git.pkginpreinstall. - Replace
.gitusing.git.pkg(with a.git.previousstaging dir) inpostinstall, and switch Intel/usr/local/Homebrewhandling from copy to rename-based replacement. - Update the release workflow to include a
.git.pkgdirectory in the pkg payload by copyingbrew/.git.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| package/scripts/preinstall | Removes any existing .git.pkg before payload install to avoid directory merges. |
| package/scripts/postinstall | Replaces .git from .git.pkg and updates Intel reinstall behavior to avoid merging into an existing .git. |
| .github/workflows/release.yml | Adds creation of brew/.git.pkg during release packaging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bo98
approved these changes
Apr 25, 2026
Member
Bo98
left a comment
There was a problem hiding this comment.
this will reset analytics settings etc so might want to restore those
aa52770 to
792d24f
Compare
- clear `.git/hooks` before privileged installer `git` operations - run repository `git` calls through `git_no_hooks` to ignore `core.hooksPath` - fail `release.yml` if future installer `git` calls skip that wrapper
792d24f to
d7ac00a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitatomically before privileged Git runs.gitduring Intel reinstalls.git.pkgbrew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex xhigh with local review and testing.