Fixed the format problem of the generated .timer file.#22107
Merged
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom Apr 29, 2026
Merged
Fixed the format problem of the generated .timer file.#22107MikeMcQuaid merged 1 commit intoHomebrew:mainfrom
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom
Conversation
MikeMcQuaid
reviewed
Apr 29, 2026
MikeMcQuaid
reviewed
Apr 29, 2026
Member
|
@choems I'll fix CI, hold for now 😁 |
… to .timer has been modified. The format of the Unit field in [Timer] has been modified so that systemd no longer issues warnings. Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
f536aca to
518b6b2
Compare
MikeMcQuaid
approved these changes
Apr 29, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks @choems, great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed two problems.
First, the format of OnCalendar. According to the manual page of systemd.time(7), it should be like this.

And this is the current format: "OnCalendar=#{@Cron[:Weekday]}-*-#{@Cron[:Month]}-#{@Cron[:Day]} #{hours}:#{minutes}:00"
The second problem is the "Unit=" field under [Timer]. It should contain the service suffix, that is, .service, otherwise you will get message like this: /home/choems/.config/systemd/user/homebrew.logrotate.timer:8: Unit type not valid, ignoring: homebrew.logrotate
brew lgtm(style, typechecking and tests) with your changes locally?