Skip to content

sorbet-runtime.rbi: use typed: strict#22122

Merged
samford merged 1 commit intomainfrom
sorbet-runtime.rbi-use-typed-strict
May 2, 2026
Merged

sorbet-runtime.rbi: use typed: strict#22122
samford merged 1 commit intomainfrom
sorbet-runtime.rbi-use-typed-strict

Conversation

@samford
Copy link
Copy Markdown
Member

@samford samford commented May 2, 2026


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes. Non-maintainers may only have one AI-assisted/generated PR open at a time.

sorbet/rbi/shims/sorbet-runtime.rbi was recently added and since then brew typecheck has been surfacing an offense due to this file using typed: true instead of typed: strict ("Sorbet/StrictSigil: Sorbet sigil should be at least strict got true."). This updates the sigil to typed: strict, as brew typecheck seems to be fine with it and I didn't see any issues when running brew tests.

Of course, let me know if this isn't a good idea (e.g., if this uses typed: true because there are known issues when using typed: strict).

Copilot AI review requested due to automatic review settings May 2, 2026 15:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • Library/Homebrew/sorbet/rbi/shims/sorbet-runtime.rbi: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

sorbet/rbi/shims/sorbet-runtime.rbi was recently added and since then
`brew typecheck` has been surfacing an offense due to this file using
`typed: true` instead of `typed: strict` ("Sorbet/StrictSigil: Sorbet
sigil should be at least strict got true."). This updates the sigil to
`typed: strict`, as `brew typecheck` seems to be fine with it and I
didn't see any issues when running `brew tests`.
@samford samford force-pushed the sorbet-runtime.rbi-use-typed-strict branch from 94b5172 to f2e40b2 Compare May 2, 2026 21:27
@samford samford enabled auto-merge May 2, 2026 21:28
@samford samford added this pull request to the merge queue May 2, 2026
Merged via the queue into main with commit c089e8d May 2, 2026
34 of 35 checks passed
@samford samford deleted the sorbet-runtime.rbi-use-typed-strict branch May 2, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants