Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/shims/sorbet-runtime.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
May 2, 2026
sorbet/rbi/shims/sorbet-runtime.rbi was recently added and since then
`brew typecheck` has been surfacing an offense due to this file using
`typed: true` instead of `typed: strict` ("Sorbet/StrictSigil: Sorbet
sigil should be at least strict got true."). This updates the sigil to
`typed: strict`, as `brew typecheck` seems to be fine with it and I
didn't see any issues when running `brew tests`.
94b5172 to
f2e40b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?sorbet/rbi/shims/sorbet-runtime.rbi was recently added and since then
brew typecheckhas been surfacing an offense due to this file usingtyped: trueinstead oftyped: strict("Sorbet/StrictSigil: Sorbet sigil should be at least strict got true."). This updates the sigil totyped: strict, asbrew typecheckseems to be fine with it and I didn't see any issues when runningbrew tests.Of course, let me know if this isn't a good idea (e.g., if this uses
typed: truebecause there are known issues when usingtyped: strict).