Skip to content

Route update-report to Rust#22126

Merged
MikeMcQuaid merged 1 commit intomainfrom
brew-rs-update-report-routing
May 3, 2026
Merged

Route update-report to Rust#22126
MikeMcQuaid merged 1 commit intomainfrom
brew-rs-update-report-routing

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

  • Keep brew update on update.sh to preserve the update flow.
  • Only re-enter brew for update-report when the Rust frontend is set.
  • Leave the existing Ruby report call unchanged for normal update runs.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes. Non-maintainers may only have one AI-assisted/generated PR open at a time.

OpenAI Codex with manual review and tweaks.


Copilot AI review requested due to automatic review settings May 2, 2026 18:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to let the experimental Rust frontend handle the update-report phase of brew update while keeping the main update flow in the existing shell script. In the broader codebase, this adjusts the frontend-routing logic for one internal command without changing the overall brew update entrypoint.

Changes:

  • Wrap the update-report call in cmd/update.sh with a Rust-frontend environment check.
  • Add update-report to the Rust frontend allowlist in brew.sh.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
Library/Homebrew/cmd/update.sh Changes how the update flow invokes update-report when the experimental Rust frontend flag is set.
Library/Homebrew/brew.sh Expands Rust frontend command routing to include the hidden update-report command.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/cmd/update.sh Outdated
Comment thread Library/Homebrew/brew.sh
@MikeMcQuaid MikeMcQuaid force-pushed the brew-rs-update-report-routing branch from f82e8f6 to adb1fcd Compare May 3, 2026 12:32
- Keep `brew update` on `update.sh` to preserve the update flow.
- Allow Rust only for `update-report` under the frontend gate.
- Cover argument forwarding and exit status in the update shell spec.
@MikeMcQuaid MikeMcQuaid force-pushed the brew-rs-update-report-routing branch from adb1fcd to c6e2c9c Compare May 3, 2026 13:25
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue May 3, 2026
Merged via the queue into main with commit 4b0158d May 3, 2026
34 of 36 checks passed
@MikeMcQuaid MikeMcQuaid deleted the brew-rs-update-report-routing branch May 3, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants