Route update-report to Rust#22126
Merged
MikeMcQuaid merged 1 commit intomainfrom May 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to let the experimental Rust frontend handle the update-report phase of brew update while keeping the main update flow in the existing shell script. In the broader codebase, this adjusts the frontend-routing logic for one internal command without changing the overall brew update entrypoint.
Changes:
- Wrap the
update-reportcall incmd/update.shwith a Rust-frontend environment check. - Add
update-reportto the Rust frontend allowlist inbrew.sh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Library/Homebrew/cmd/update.sh |
Changes how the update flow invokes update-report when the experimental Rust frontend flag is set. |
Library/Homebrew/brew.sh |
Expands Rust frontend command routing to include the hidden update-report command. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ZhongRuoyu
approved these changes
May 3, 2026
f82e8f6 to
adb1fcd
Compare
- Keep `brew update` on `update.sh` to preserve the update flow. - Allow Rust only for `update-report` under the frontend gate. - Cover argument forwarding and exit status in the update shell spec.
adb1fcd to
c6e2c9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew updateonupdate.shto preserve the update flow.brewforupdate-reportwhen the Rust frontend is set.brew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex with manual review and tweaks.