caveats: warn when formula executables are shadowed on PATH#22130
Draft
HaraldNordgren wants to merge 1 commit intoHomebrew:mainfrom
Draft
caveats: warn when formula executables are shadowed on PATH#22130HaraldNordgren wants to merge 1 commit intoHomebrew:mainfrom
HaraldNordgren wants to merge 1 commit intoHomebrew:mainfrom
Conversation
MikeMcQuaid
reviewed
May 3, 2026
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks!
This seems like it might be pretty slow? Can you try some before/after benchmarks with hyperfine?
May also warrant an opt-out here.
|
|
||
| sig { returns(T.nilable(String)) } | ||
| def shadowed_path_text | ||
| return if formula.keg_only? |
Member
There was a problem hiding this comment.
The keg-only formula may be being linked: worth handling that case I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a formula installs an executable whose name is already taken by something earlier on the user's PATH (different brew prefix, asdf/mise shim, system tool, manually-installed binary), running the command by name silently invokes the other one. There is currently no signal that this is happening.