Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes Homebrew’s internal-API selection so developer-mode users default to the internal packages endpoint instead of needing to opt in via HOMEBREW_USE_INTERNAL_API. In the codebase, this affects the central environment/configuration gate that all API consumers consult.
Changes:
- Make
EnvConfig.use_internal_api?returntrueforHOMEBREW_DEVELOPERusers. - Make
EnvConfig.use_internal_api?returntruefor persisteddevcmdrunusers (brew developer on/ dev command run). - Keep
HOMEBREW_NO_INSTALL_FROM_APIas a higher-priority opt-out.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sig { returns(T::Boolean) } | ||
| def use_internal_api? | ||
| return false if Homebrew::EnvConfig.no_install_from_api? | ||
| return true if Homebrew::EnvConfig.developer? || Homebrew::EnvConfig.devcmdrun? |
Member
There was a problem hiding this comment.
@Rylan12 Should probably set this in brew.sh instead as then it'll take effect in update.sh and other Bash code.
| sig { returns(T::Boolean) } | ||
| def use_internal_api? | ||
| return false if Homebrew::EnvConfig.no_install_from_api? | ||
| return true if Homebrew::EnvConfig.developer? || Homebrew::EnvConfig.devcmdrun? |
| sig { returns(T::Boolean) } | ||
| def use_internal_api? | ||
| return false if Homebrew::EnvConfig.no_install_from_api? | ||
| return true if Homebrew::EnvConfig.developer? || Homebrew::EnvConfig.devcmdrun? |
Member
Author
|
Oof, not as simple as I thought I guess 😓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's switch all developers and devcmdrun folks to use the internal API
Disabling the API with
HOMEBREW_NO_INSTALL_FROM_APIstill works for these people. Non-developers can opt-in still withHOMEBREW_USE_INTERNAL_API.brew lgtm(style, typechecking and tests) with your changes locally?