Skip to content

Warn for Nix-managed Homebrew#22182

Merged
MikeMcQuaid merged 2 commits intomainfrom
nix-darwin-issue-reporting-warning
May 8, 2026
Merged

Warn for Nix-managed Homebrew#22182
MikeMcQuaid merged 2 commits intomainfrom
nix-darwin-issue-reporting-warning

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented May 8, 2026

We've had a few issues in last wee while coming from Nix due to how they handle Homebrew in an unsupported fashion (e.g. #22174). We have no desire to intentionally break things there but we should make clear that users Homebrew through Nix should file their issues with the upstream instead.

  • Direct Nix-managed crash reports to upstream Nix projects.
  • Treat nix-homebrew markers as Tier 3 for brew doctor.
  • Document Nix-managed Homebrew in Support-Tiers.md.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes. Non-maintainers may only have one AI-assisted/generated PR open at a time.

OpenAI Codex 5.5 xhigh with local tweaking.


- Direct Nix-managed crash reports to upstream Nix projects.
- Treat `nix-homebrew` markers as Tier 3 for `brew doctor`.
- Document Nix-managed Homebrew in `Support-Tiers.md`.
@MikeMcQuaid MikeMcQuaid requested a review from a team as a code owner May 8, 2026 13:36
Copilot AI review requested due to automatic review settings May 8, 2026 13:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds explicit detection of Nix-managed Homebrew installs and adjusts diagnostics/error-reporting guidance to redirect users to the appropriate upstream Nix projects, while documenting this setup as Tier 3 support.

Changes:

  • Add OS-level detection helpers for Nix-managed Homebrew (nix-homebrew + nix-darwin) and set OS::ISSUES_URL accordingly.
  • Introduce a brew doctor check warning that Nix-managed installs are Tier 3 and pointing to upstream issue trackers.
  • Centralize issue-reporting text formatting and document Nix-managed installs in Support Tiers docs; add specs for the new OS/doctor behavior.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Library/Homebrew/utils/output.rb Adds a shared issue_reporting_message formatter used by multiple error-reporting sites.
Library/Homebrew/os.rb Detects Nix-managed installs and switches issue-reporting URLs to upstream Nix trackers.
Library/Homebrew/diagnostic.rb Adds check_for_nix_homebrew to warn in brew doctor and point to Tier 3 + upstream tracker.
Library/Homebrew/exceptions.rb Uses the shared issue-reporting formatter and redirects “official” issue guidance for Nix-managed installs.
Library/Homebrew/brew.rb Uses the shared issue-reporting formatter and redirects internal-command crash reporting under Nix management.
Library/Homebrew/test/os_spec.rb Adds unit tests for nix-homebrew/nix-darwin detection.
Library/Homebrew/test/diagnostic_checks_spec.rb Adds coverage for the new Nix-related brew doctor check.
docs/Support-Tiers.md Documents Nix-managed Homebrew installs as Tier 3.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/test/os_spec.rb
Comment thread docs/Support-Tiers.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@MikeMcQuaid MikeMcQuaid enabled auto-merge May 8, 2026 13:50
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue May 8, 2026
Merged via the queue into main with commit 6839384 May 8, 2026
43 checks passed
@MikeMcQuaid MikeMcQuaid deleted the nix-darwin-issue-reporting-warning branch May 8, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants