Add ask dependency plans and cask support#22275
Draft
MikeMcQuaid wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands --ask behavior to show dependency plans for formula and cask install/upgrade/reinstall flows, and updates user-facing documentation/completions accordingly.
Changes:
- Adds dependency-plan output for formulae and casks, including added/changed/removed closure entries.
- Wires cask
--askhandling into install, upgrade, and reinstall paths. - Updates manpage, docs, env config, and shell completion descriptions for
--ask.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
Library/Homebrew/install.rb |
Implements formula/cask ask-plan output and configurable prompt action text. |
Library/Homebrew/cmd/install.rb |
Moves cask ask handling to planned fetch casks and adds ask-mode hints. |
Library/Homebrew/cmd/upgrade.rb |
Adds cask ask handling for discovered outdated casks and updates option text. |
Library/Homebrew/cmd/reinstall.rb |
Adds cask ask action wording for reinstall and updates option text. |
Library/Homebrew/env_config.rb |
Updates HOMEBREW_ASK description. |
Library/Homebrew/test/cmd/install_spec.rb |
Adds tests for formula/cask ask-plan output and hints. |
Library/Homebrew/test/cmd/upgrade_spec.rb |
Adds cask upgrade ask test. |
docs/Manpage.md |
Updates generated/user documentation text. |
manpages/brew.1 |
Updates generated manpage text. |
completions/fish/brew.fish |
Updates fish completion descriptions. |
completions/zsh/_brew |
Updates zsh completion descriptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4a8c230 to
2af7b4f
Compare
- Show added, changed and removed packages before `--ask` mutates installs, upgrades or reinstalls. - Include cask dependency support so `HOMEBREW_ASK` covers both cask and formula changes. - Keep `--ask` prompts ahead of formula and cask downloads.
2af7b4f to
271520a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--askmutates installs, upgrades or reinstalls.--ask/HOMEBREW_ASKcovers both cask and formula changes.brew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex 5.5 xhigh with local review and testing