Skip to content

Add ask dependency plans and cask support#22275

Draft
MikeMcQuaid wants to merge 1 commit into
mainfrom
ask-cask-dependency-plans
Draft

Add ask dependency plans and cask support#22275
MikeMcQuaid wants to merge 1 commit into
mainfrom
ask-cask-dependency-plans

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

  • Show added, changed and removed packages before --ask mutates installs, upgrades or reinstalls.
  • Include cask dependency support so --ask/HOMEBREW_ASK covers both cask and formula changes.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes. Non-maintainers may only have one AI-assisted/generated PR open at a time.

OpenAI Codex 5.5 xhigh with local review and testing


Copilot AI review requested due to automatic review settings May 14, 2026 07:54
@MikeMcQuaid MikeMcQuaid marked this pull request as draft May 14, 2026 07:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands --ask behavior to show dependency plans for formula and cask install/upgrade/reinstall flows, and updates user-facing documentation/completions accordingly.

Changes:

  • Adds dependency-plan output for formulae and casks, including added/changed/removed closure entries.
  • Wires cask --ask handling into install, upgrade, and reinstall paths.
  • Updates manpage, docs, env config, and shell completion descriptions for --ask.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Library/Homebrew/install.rb Implements formula/cask ask-plan output and configurable prompt action text.
Library/Homebrew/cmd/install.rb Moves cask ask handling to planned fetch casks and adds ask-mode hints.
Library/Homebrew/cmd/upgrade.rb Adds cask ask handling for discovered outdated casks and updates option text.
Library/Homebrew/cmd/reinstall.rb Adds cask ask action wording for reinstall and updates option text.
Library/Homebrew/env_config.rb Updates HOMEBREW_ASK description.
Library/Homebrew/test/cmd/install_spec.rb Adds tests for formula/cask ask-plan output and hints.
Library/Homebrew/test/cmd/upgrade_spec.rb Adds cask upgrade ask test.
docs/Manpage.md Updates generated/user documentation text.
manpages/brew.1 Updates generated manpage text.
completions/fish/brew.fish Updates fish completion descriptions.
completions/zsh/_brew Updates zsh completion descriptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/install.rb Outdated
Comment thread Library/Homebrew/cmd/reinstall.rb Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Comment thread Library/Homebrew/install.rb Outdated
- Show added, changed and removed packages before `--ask`
  mutates installs, upgrades or reinstalls.
- Include cask dependency support so `HOMEBREW_ASK`
  covers both cask and formula changes.
- Keep `--ask` prompts ahead of formula and cask downloads.
@MikeMcQuaid MikeMcQuaid force-pushed the ask-cask-dependency-plans branch from 2af7b4f to 271520a Compare May 14, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants