bundle/krew: use kubectl-krew directly#22328
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
A kubectl plugin is just a kubectl-* executable on PATH, so this PR simplifies the Krew bundle extension by locating and invoking kubectl-krew directly instead of going through kubectl krew …. This removes the need for the separate package_manager_installed? probe (which previously shelled out to kubectl krew version) and lets the base class's executable-presence check do the work.
Changes:
- Switch
package_manager_executablelookup fromkubectltokubectl-krew. - Drop the custom
package_manager_installed?override and its@krew_installedcache. - Update
packagesandinstall_package!to call thekubectl-krewbinary without the"krew"subcommand argument.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
reviewed
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?A kubectl extension is just a
kubectl-*executable on PATH, so we can simplify a bit here and just invokekubectl-krewdirectly