Fix npm bundle dump PATH#22332
Merged
Merged
Conversation
- Ensure `npm list` runs with npm's directory on `PATH`. - This lets `/usr/bin/env node` resolve Homebrew's `node`. - Add a regression for absolute npm shims.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes brew bundle dump for npm packages by ensuring npm list is executed with the npm executable’s directory prepended to PATH, allowing /usr/bin/env node to resolve Homebrew’s node when npm is invoked via an absolute shim.
Changes:
- Wrap the
npm list -g --jsoninvocation inwith_env(package_manager_env(npm))soPATHincludes the npm directory. - Add an RSpec regression test asserting npm’s directory is placed at the front of
PATHduring package listing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/bundle/extensions/npm.rb | Ensures npm list runs under a PATH that includes the npm executable’s directory. |
| Library/Homebrew/test/bundle/npm_spec.rb | Adds a regression test validating PATH behavior for absolute npm shims during dumping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SMillerDev
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm listruns with npm's directory onPATH./usr/bin/env noderesolve Homebrew'snode.Fixes #22331
brew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex 5.5 xhigh with manual review and testing.