info: mark deprecated/disabled pkg in install status#22334
Conversation
e3b96cc to
2bda7f6
Compare
We're saying 3 times in this output that ffmpeg@2.8 is deprecated. Do we need to do it this many? Also, I don't think this really makes sense under "Installed Kegs and Versions" because the keg isn't deprecated. |
2bda7f6 to
1e1cd73
Compare
|
@MikeMcQuaid Yeah, maybe that's a bit overkill. Pushed a new version now. |
|
@HaraldNordgren sorry, being lazy: mind pasting the new output when you're changing? |
1e1cd73 to
69b7628
Compare
|
@MikeMcQuaid Sure! I took the opportunity to also add in "(disabled)" which I found when trying to find some nice output for this. I also refactored to use this helper for search, but left the uninstall markers turned off for search to not create too big of a change, but I wouldn't mind turning them on as well. Here is the new output: |
Match the '(deprecated)'/'(disabled)' suffix already shown by 'brew search'. Apply it via 'pretty_install_status' so it shows in the 'brew info' title and 'brew tap-info' formula/cask listings, and refactor 'brew search' to use the same helper.
69b7628 to
3df4930
Compare
I think we shouldn't have uninstall markers for search. Install markers maybe seem fine but the assumption would be that things you are searching for will not be installed. |
Mark deprecated formula and deprecated siblings in
brew info:brew lgtm(style, typechecking and tests) with your changes locally?Claud Code, Extra High