Skip to content

info, tap-info: skip uninstalled marker and bold when not a problem (align with search)#22342

Merged
MikeMcQuaid merged 1 commit into
Homebrew:mainfrom
HaraldNordgren:tap-info-uninstalled-no-mark
May 19, 2026
Merged

info, tap-info: skip uninstalled marker and bold when not a problem (align with search)#22342
MikeMcQuaid merged 1 commit into
Homebrew:mainfrom
HaraldNordgren:tap-info-uninstalled-no-mark

Conversation

@HaraldNordgren
Copy link
Copy Markdown
Contributor

Aligns uninstalled formulae with how brew search works.

  • For brew tap-info: Uninstalled formulae won't be bolded and not have the red X.
  • For brew info: A non-installed dependency is not a problem before the formula itself is installed so won't show the red X. When the formula is installed, then a missing dep is a problem, so that should be highlighted with bold and a red X.
❯ brew tap-info facebook/fb
...
==> Formulae
buck                 fbsimctl             fbthrift-compiler    idb-companion ✔      watchman             xar

❯ brew info pyside@2
==> pyside@2 ✘ (disabled): stable 5.15.17 (bottled) [keg-only]
...
==> Dependencies
Required (3): llvm ✔, python@3.10, qt@5

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

Claud Code, Extra High


The red ✘ uninstalled marker reads as an error, but in some places
uninstalled is the norm rather than a problem:

- tap-info: every uninstalled formula/cask in the tap catalog
- brew info <pkg>: deps and requirements when the package itself is
  not installed (the listing just shows what would be pulled in)

Add a 'mark_uninstalled:' parameter to 'pretty_install_status' that,
when false, returns the plain string instead of the red ✘. Pass it
through 'decorate_dependencies'/'decorate_requirements' in both
'cmd/info' and 'cask/info', and use it unconditionally in 'tap-info'.

Keep the marker where missing really signals a problem: info headers,
deps/requirements of an installed package, and update reports for
removed entries.
@HaraldNordgren HaraldNordgren changed the title info, tap-info: skip uninstalled marker when not a problem info, tap-info: skip uninstalled marker and bold when not a problem (align with search) May 19, 2026
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is great, thanks again @HaraldNordgren!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue May 19, 2026
Merged via the queue into Homebrew:main with commit 5224c65 May 19, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants