Skip to content

completions: add missing require.#22366

Merged
MikeMcQuaid merged 1 commit into
mainfrom
completions_link_tap
May 21, 2026
Merged

completions: add missing require.#22366
MikeMcQuaid merged 1 commit into
mainfrom
completions_link_tap

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

Fixes #22364.


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes. Non-maintainers may only have one AI-assisted/generated PR open at a time.

Done by ✋🏻


Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes brew completions link / brew completions unlink failing with Error: uninitialized constant Homebrew::Completions::Tap by ensuring the Tap implementation is loaded when Homebrew::Completions is required.

Changes:

  • Add a missing require "tap" to Library/Homebrew/completions.rb so Tap.installed is available.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/completions.rb
@carlocab
Copy link
Copy Markdown
Member

Done by ✋🏻

shocking

@MikeMcQuaid
Copy link
Copy Markdown
Member Author

@carlocab 👴🏻 still got it

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit fe40380 May 21, 2026
41 checks passed
@MikeMcQuaid MikeMcQuaid deleted the completions_link_tap branch May 21, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew completions link and brew completions unlink fail with Error: uninitialized constant Homebrew::Completions::Tap

3 participants